Configure libphonenumber-for-php-lite to be replaced by this package #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 8, 2024
|
Thanks, that makes sense. You've just missed Google's two weekly release, so it'll be a little while until there is a new tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libphonenumber-for-php-liteis currently configured to conflict withlibphonenumber-for-php. This leads to both packages not being able to be installed simultaneously, which is of course intended behavior.However, this breaks the dependency chain for packages requiring either of them.
Imagine the following scenario:
project dependencies
some-package dependencies
This will fail because of the conflict configuration.
It'd be better to:
libphonenumber-for-phpto replacelibphonenumber-for-php-litelibphonenumber-for-php-litereplacemeans: this package provides everything the other package has as well in the very same namespace (and probably more).This way,
libphonenumber-for-php-litegets installed when it's the only package requested from the family. But whenever any dependency (either project or package) requireslibphonenumber-for-php, only that gets installed without conflict failures 'cause everythinglitehas to offer is defined to be also available in the original.